From: Jesper Juhl <jj@chaosbits.net>
Date: Mon, 9 Apr 2012 20:50:10 +0000 (+0200)
Subject: typhoon: get rid of redundant conditional before all to release_firmware()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=b2cbf2e31bd26abaddcb1ce4cefb09e025247d52;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

typhoon: get rid of redundant conditional before all to release_firmware()

There's no need to test for a NULL pointer before calling
release_firmware() since the function does that check itself, so
remove the redundant test.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: David Dillow <dave@thedillows.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c
index 1234a14b2b73..b15366635147 100644
--- a/drivers/net/ethernet/3com/typhoon.c
+++ b/drivers/net/ethernet/3com/typhoon.c
@@ -2549,8 +2549,7 @@ typhoon_init(void)
 static void __exit
 typhoon_cleanup(void)
 {
-	if (typhoon_fw)
-		release_firmware(typhoon_fw);
+	release_firmware(typhoon_fw);
 	pci_unregister_driver(&typhoon_driver);
 }