From: Maxime Ripard Date: Sat, 2 May 2015 15:03:21 +0000 (+0200) Subject: clk: asm9260: Fix of_io_request_and_map error check X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=b1ed311baf66d7e826f07f456b9f7945fa300aaf;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git clk: asm9260: Fix of_io_request_and_map error check of_io_request_and map returns an error pointer, but the current code assumes that on error the returned pointer will be NULL. Obviously, that makes the check completely useless. Change the test to actually check for the proper error code. Signed-off-by: Maxime Ripard Cc: Mike Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/clk-asm9260.c b/drivers/clk/clk-asm9260.c index 88f4ff6916fe..90897af8d9f7 100644 --- a/drivers/clk/clk-asm9260.c +++ b/drivers/clk/clk-asm9260.c @@ -274,7 +274,7 @@ static void __init asm9260_acc_init(struct device_node *np) u32 accuracy = 0; base = of_io_request_and_map(np, 0, np->name); - if (!base) + if (IS_ERR(base)) panic("%s: unable to map resource", np->name); /* register pll */