From: Dan Carpenter Date: Mon, 3 Jan 2011 05:47:40 +0000 (+0300) Subject: Staging: tm6000: silence Sparse warning "dubious: !x | !y" X-Git-Tag: MMI-PSA29.97-13-9~20521^2~855 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=b01627c608d97b5246eb7a4b75c40f2a1fb4dc30;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git Staging: tm6000: silence Sparse warning "dubious: !x | !y" Bitwise and logical or are the equivalent here, so this doesn't affect runtime, but logical or was intended. The original code causes a warning in Sparse: "warning: dubious: !x | !y" Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/tm6000/tm6000-input.c b/drivers/staging/tm6000/tm6000-input.c index 21e7da40f049..01fcbbe38409 100644 --- a/drivers/staging/tm6000/tm6000-input.c +++ b/drivers/staging/tm6000/tm6000-input.c @@ -374,7 +374,7 @@ int tm6000_ir_init(struct tm6000_core *dev) ir = kzalloc(sizeof(*ir), GFP_KERNEL); rc = rc_allocate_device(); - if (!ir | !rc) + if (!ir || !rc) goto out; /* record handles to ourself */