From: Axel Lin Date: Mon, 31 Oct 2011 06:23:03 +0000 (+0800) Subject: mfd: Set da903x bits if new value is different from the old one X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=af65e6cef488be0bd15932c8ce9801a47a183051;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git mfd: Set da903x bits if new value is different from the old one It does not make sense to write new value only when all the bit_mask bits are zero. We need to write new value if the bit mask fields of new value is not equal to old value. Signed-off-by: Axel Lin Signed-off-by: Samuel Ortiz --- diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c index 62ce685a79c..1924b857a0f 100644 --- a/drivers/mfd/da903x.c +++ b/drivers/mfd/da903x.c @@ -182,7 +182,7 @@ int da903x_set_bits(struct device *dev, int reg, uint8_t bit_mask) if (ret) goto out; - if ((reg_val & bit_mask) == 0) { + if ((reg_val & bit_mask) != bit_mask) { reg_val |= bit_mask; ret = __da903x_write(chip->client, reg, reg_val); }