From: Sachin Kamat Date: Mon, 29 Apr 2013 23:20:09 +0000 (-0700) Subject: drivers/rtc/rtc-tps6586x.c: remove incorrect use of rtc_device_unregister X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=ad3f3cf489311af25f91bade664a1688896245e9;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git drivers/rtc/rtc-tps6586x.c: remove incorrect use of rtc_device_unregister Device managed functions do not need explicit freeing/unregistering. Moreover in this case it was done using non-device managed function which is incorrect. Hence remove it. Signed-off-by: Sachin Kamat Cc: Laxman dewangan Cc: Chiwoong Byun Cc: Jonghwa Lee Cc: Venu Byravarasu Cc: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index badfea491a93..459c2ffc95a6 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -289,15 +289,12 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) if (ret < 0) { dev_err(&pdev->dev, "request IRQ(%d) failed with ret %d\n", rtc->irq, ret); - goto fail_req_irq; + goto fail_rtc_register; } disable_irq(rtc->irq); device_set_wakeup_capable(&pdev->dev, 1); return 0; -fail_req_irq: - rtc_device_unregister(rtc->rtc); - fail_rtc_register: tps6586x_update(tps_dev, RTC_CTRL, 0, RTC_ENABLE | OSC_SRC_SEL | PRE_BYPASS | CL_SEL_MASK);