From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 25 Nov 2014 21:33:45 +0000 (+0100)
Subject: net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=aa99c47933d2c9a7622440d1b08ebb46ad8bd741;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"

The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 6b463117dcac..6fc834e4306d 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -561,9 +561,7 @@ int netvsc_device_remove(struct hv_device *device)
 	vmbus_close(device->channel);
 
 	/* Release all resources */
-	if (net_device->sub_cb_buf)
-		vfree(net_device->sub_cb_buf);
-
+	vfree(net_device->sub_cb_buf);
 	free_netvsc_device(net_device);
 	return 0;
 }