From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 4 Jan 2016 05:13:21 +0000 (+1100)
Subject: XFS: Use a signed return type for suffix_kstrtoint()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a841b64df29b4c7e68ce564d752dfb2042db5404;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

XFS: Use a signed return type for suffix_kstrtoint()

The return type "unsigned long" was used by the suffix_kstrtoint()
function even though it will eventually return a negative error code.
Improve this implementation detail by using the type "int" instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 36bd8825bfb0..b35775752b74 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -137,7 +137,7 @@ static const match_table_t tokens = {
 };
 
 
-STATIC unsigned long
+STATIC int
 suffix_kstrtoint(char *s, unsigned int base, int *res)
 {
 	int	last, shift_left_factor = 0, _res;