From: Krzysztof Kozlowski Date: Wed, 28 Jun 2017 14:56:20 +0000 (+0200) Subject: PM / Domains: Fix unsafe iteration over modified list of domains X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a7e2d1bce4c1db471f1cbc0c4666a3112bbf0994;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git PM / Domains: Fix unsafe iteration over modified list of domains of_genpd_remove_last() iterates over list of domains and removes matching element thus it has to use safe version of list iteration. Fixes: 17926551c98a (PM / Domains: Add support for removing nested PM domains by provider) Cc: 4.9+ # 4.9+ Signed-off-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 0b836fdc99ad..e342408cfb8d 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1980,14 +1980,14 @@ EXPORT_SYMBOL_GPL(of_genpd_add_subdomain); */ struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) { - struct generic_pm_domain *gpd, *genpd = ERR_PTR(-ENOENT); + struct generic_pm_domain *gpd, *tmp, *genpd = ERR_PTR(-ENOENT); int ret; if (IS_ERR_OR_NULL(np)) return ERR_PTR(-EINVAL); mutex_lock(&gpd_list_lock); - list_for_each_entry(gpd, &gpd_list, gpd_list_node) { + list_for_each_entry_safe(gpd, tmp, &gpd_list, gpd_list_node) { if (gpd->provider == &np->fwnode) { ret = genpd_remove(gpd); genpd = ret ? ERR_PTR(ret) : gpd;