From: Denis V. Lunev Date: Tue, 15 Jan 2008 06:56:01 +0000 (-0800) Subject: [ARP]: Move inet_addr_type call after simple error checks in arp_contructor. X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a79878f00dad97d03a3e62a48b06227d55ae5fe4;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git [ARP]: Move inet_addr_type call after simple error checks in arp_contructor. The neighbour entry will be destroyed in the case of error, so it is pointless to perform constly routing table lookup in this case. Signed-off-by: Denis V. Lunev Signed-off-by: David S. Miller --- diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index 3f0730ec0a21..d12f31b0c107 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -235,8 +235,6 @@ static int arp_constructor(struct neighbour *neigh) struct in_device *in_dev; struct neigh_parms *parms; - neigh->type = inet_addr_type(&init_net, addr); - rcu_read_lock(); in_dev = __in_dev_get_rcu(dev); if (in_dev == NULL) { @@ -244,6 +242,8 @@ static int arp_constructor(struct neighbour *neigh) return -EINVAL; } + neigh->type = inet_addr_type(&init_net, addr); + parms = in_dev->arp_parms; __neigh_parms_put(neigh->parms); neigh->parms = neigh_parms_clone(parms);