From: Markus Elfring Date: Sat, 27 Jun 2015 20:05:31 +0000 (+0200) Subject: drm/msm/dsi: Delete an unnecessary check before the function call "dsi_destroy" X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a60bbb2764b73a3f54c7462f3d28f960b7811682;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git drm/msm/dsi: Delete an unnecessary check before the function call "dsi_destroy" The dsi_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Rob Clark --- diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 1f2561e2ff71..dc4f38f70286 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -110,9 +110,7 @@ static struct msm_dsi *dsi_init(struct platform_device *pdev) return msm_dsi; fail: - if (msm_dsi) - dsi_destroy(msm_dsi); - + dsi_destroy(msm_dsi); return ERR_PTR(ret); }