From: Breno Leitao Date: Mon, 23 May 2011 03:36:35 +0000 (+0000) Subject: ehea: Fix multicast registration on semi-promiscuous mode X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a4910b744486254cfa61995954c118fb2283c4fd;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git ehea: Fix multicast registration on semi-promiscuous mode Ehea will not register multicast groups in phyp if the physical interface is in promiscuous mode. But it should register if the logical port is in promiscuous mode, but the physical port is not. Ehea physical promiscuous mode is defined by ehea_port->promisc, while logical port is defined by IFF_PROMISC. So currently, if the user set the interface in promiscuous mode, IGMP will not be registred in PHYP, and PHYP will never pass the multicast packet to the logical port, which is bad So, this patch just fixes it, assuring that we register in phyp if the physical port is not on promiscuous mode. Signed-off-by: Breno Leitao Signed-off-by: David S. Miller --- diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c index 6a0a8fca62b..3fd5a240034 100644 --- a/drivers/net/ehea/ehea_main.c +++ b/drivers/net/ehea/ehea_main.c @@ -2083,7 +2083,7 @@ static void ehea_set_multicast_list(struct net_device *dev) struct netdev_hw_addr *ha; int ret; - if (dev->flags & IFF_PROMISC) { + if (port->promisc) { ehea_promiscuous(dev, 1); return; }