From: Dan Carpenter Date: Fri, 2 Apr 2010 11:31:50 +0000 (-0300) Subject: V4L/DVB: cx88: improve error handling X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a41b2ea73ad81bb42364841b37d4c3830a53dc0d;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git V4L/DVB: cx88: improve error handling Return -EINVAL if we don't find the right query control id. Signed-off-by: Dan Carpenter Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c index f5d1d89bdc2..0fab65c3ab3 100644 --- a/drivers/media/video/cx88/cx88-video.c +++ b/drivers/media/video/cx88/cx88-video.c @@ -1538,9 +1538,12 @@ static int radio_queryctrl (struct file *file, void *priv, c->id >= V4L2_CID_LASTP1) return -EINVAL; if (c->id == V4L2_CID_AUDIO_MUTE) { - for (i = 0; i < CX8800_CTLS; i++) + for (i = 0; i < CX8800_CTLS; i++) { if (cx8800_ctls[i].v.id == c->id) break; + } + if (i == CX8800_CTLS) + return -EINVAL; *c = cx8800_ctls[i].v; } else *c = no_ctl;