From: Matthias Schmidt <gravatronics@live.com>
Date: Fri, 27 Sep 2019 15:00:35 +0000 (+0200)
Subject: Resolve TODOs related to `wcf1_reaction_type` table
X-Git-Tag: 5.2.0_Beta_2~29^2~4
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a269a731396a8f7f3af3064f072b11c09704811a;p=GitHub%2FWoltLab%2FWCF.git

Resolve TODOs related to `wcf1_reaction_type` table
---

diff --git a/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php b/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php
index 6884f7afb9..f4cef76852 100644
--- a/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php
+++ b/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php
@@ -149,12 +149,11 @@ $tables = [
 	DatabaseTable::create('wcf1_reaction_type')
 		->columns([
 			ObjectIdDatabaseTableColumn::create('reactionTypeID'),
-			// TODO: is currently not `not null`
 			NotNullVarchar255DatabaseTableColumn::create('title'),
 			NotNullInt10DatabaseTableColumn::create('showOrder')
 				->defaultValue(0),
-			// TODO: should be varchar
-			MediumtextDatabaseTableColumn::create('iconFile'),
+			NotNullVarchar255DatabaseTableColumn::create('iconFile')
+				->defaultValue(''),
 			DefaultFalseBooleanDatabaseTableColumn::create('isDisabled')
 		])
 		->indices([