From: Chao Yu Date: Mon, 18 May 2015 08:43:02 +0000 (+0800) Subject: ubifs: fix to check error code of register_shrinker X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a1fe33af5f8c5f5aebe68d22125d19e48b8e601c;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git ubifs: fix to check error code of register_shrinker register_shrinker() in ubifs_init() can fail due to fail to call kzalloc. This patch fixes to check the return value of register_shrinker, otherwise our shrinker may be unregistered after ubifs initialized successfully. Signed-off-by: Chao Yu Signed-off-by: Artem Bityutskiy Signed-off-by: Richard Weinberger --- diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 75e6f04bb795..fa83d1bbba44 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -2245,7 +2245,9 @@ static int __init ubifs_init(void) if (!ubifs_inode_slab) return -ENOMEM; - register_shrinker(&ubifs_shrinker_info); + err = register_shrinker(&ubifs_shrinker_info); + if (err) + goto out_slab; err = ubifs_compressors_init(); if (err) @@ -2269,6 +2271,7 @@ out_compr: ubifs_compressors_exit(); out_shrinker: unregister_shrinker(&ubifs_shrinker_info); +out_slab: kmem_cache_destroy(ubifs_inode_slab); return err; }