From: Alexander Ebert <ebert@woltlab.com>
Date: Tue, 25 Nov 2014 18:25:14 +0000 (+0100)
Subject: Fixed NS_ERROR_FAILURE in Firefox related to code.showCode()
X-Git-Tag: 2.1.0_Beta_1~159^2~1
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a1fa12a3b59b7d95adb9ed4f8d683eae74497a62;p=GitHub%2FWoltLab%2FWCF.git

Fixed NS_ERROR_FAILURE in Firefox related to code.showCode()

Invoking setSelectionRange() on a <textarea> contained in a hidden element (display: none) will invoke NS_ERROR_FAILURE without any further error message. This is an attempt to work around by code.showCode() which is unaware of this fact.
---

diff --git a/wcfsetup/install/files/js/3rdParty/redactor/plugins/wmonkeypatch.js b/wcfsetup/install/files/js/3rdParty/redactor/plugins/wmonkeypatch.js
index b686f3a80c..ea4cd16e1f 100644
--- a/wcfsetup/install/files/js/3rdParty/redactor/plugins/wmonkeypatch.js
+++ b/wcfsetup/install/files/js/3rdParty/redactor/plugins/wmonkeypatch.js
@@ -277,6 +277,23 @@ RedactorPlugins.wmonkeypatch = function() {
 				
 				return $mpTextareaIndenting.call(this, e);
 			}).bind(this);
+			
+			// code.showCode
+			// fixes an issue related to setSelectionRange on a hidden textarea in Firefox (NS_ERROR_FAILURE, #1984)
+			var $mpShowCode = this.code.showCode;
+			this.code.showCode = (function() {
+				var $hiddenParent = null;
+				if (!this.$textarea.is(':visible')) {
+					$hiddenParent = this.$textarea.parentsUntil(':visible').last();
+					$hiddenParent.show();
+				}
+				
+				$mpShowCode.call(this);
+				
+				if ($hiddenParent !== null) {
+					$hiddenParent.hide();
+				}
+			}).bind(this);
 		},
 		
 		/**