From: Guenter Roeck Date: Fri, 17 Aug 2012 03:25:59 +0000 (-0700) Subject: spi: spi-coldfire-qspi: Drop extra spi_master_put in device remove function X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a0c3652caa357b8f4e76efe401646ef298483cd9;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git spi: spi-coldfire-qspi: Drop extra spi_master_put in device remove function The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which and results in device memory being freed. The subsequent call to spi_master_put is unnecessary and results in an access to free memory. Drop it. Signed-off-by: Guenter Roeck Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c index b2d4b9e4e010..1a30b47465cb 100644 --- a/drivers/spi/spi-coldfire-qspi.c +++ b/drivers/spi/spi-coldfire-qspi.c @@ -533,7 +533,6 @@ static int __devexit mcfqspi_remove(struct platform_device *pdev) iounmap(mcfqspi->iobase); release_mem_region(res->start, resource_size(res)); spi_unregister_master(master); - spi_master_put(master); return 0; }