From: Dan Carpenter Date: Mon, 19 Oct 2015 10:18:05 +0000 (+0300) Subject: mfd: arizona: Signedness bug in arizona_runtime_suspend() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=a05950a4453fcfb136ee1eff0bd0a3cfb46a401e;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git mfd: arizona: Signedness bug in arizona_runtime_suspend() The "jd_active" variable needs to be signed for the error handling to work. Fixes: 143e5887ae57 ('mfd: arizona: factor out checking of jack detection state') Signed-off-by: Dan Carpenter Acked-by: Charles Keepax Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 4e49210f7a5b..d474732cc65c 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -628,7 +628,7 @@ err: static int arizona_runtime_suspend(struct device *dev) { struct arizona *arizona = dev_get_drvdata(dev); - unsigned int jd_active = 0; + int jd_active = 0; int ret; dev_dbg(arizona->dev, "Entering AoD mode\n");