From: Dan Carpenter <error27@gmail.com> Date: Sat, 14 Aug 2010 09:01:45 +0000 (+0200) Subject: dma/shdma: move dereference below the NULL check X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=9f9ff20d46c6728b092f34b6a642e1e81ab5e254;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git dma/shdma: move dereference below the NULL check "param" can be NULL here, so only dereference it after the check. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- diff --git a/drivers/dma/shdma.c b/drivers/dma/shdma.c index fb64cf36ba61..eb6b54dbb806 100644 --- a/drivers/dma/shdma.c +++ b/drivers/dma/shdma.c @@ -580,7 +580,6 @@ static struct dma_async_tx_descriptor *sh_dmae_prep_slave_sg( sh_chan = to_sh_chan(chan); param = chan->private; - slave_addr = param->config->addr; /* Someone calling slave DMA on a public channel? */ if (!param || !sg_len) { @@ -589,6 +588,8 @@ static struct dma_async_tx_descriptor *sh_dmae_prep_slave_sg( return NULL; } + slave_addr = param->config->addr; + /* * if (param != NULL), this is a successfully requested slave channel, * therefore param->config != NULL too.