From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 31 Aug 2017 05:58:17 +0000 (+0200)
Subject: Revert "gpiolib: request the gpio before querying its direction"
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=9e238e380c2a8aff21d37f713b5c24b079a726a5;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

Revert "gpiolib: request the gpio before querying its direction"

This reverts commit 108d23e322a247d9f89ba2e2742520ead0944cc9.
It turns out this causes a regression on the OMAP, Marvell
and Renesas.

Reported-by: Tony Lindgren <tony@atomide.com>
Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reported-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e452768f316d..eb80dac4e26a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1221,14 +1221,6 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data)
 		struct gpio_desc *desc = &gdev->descs[i];
 
 		desc->gdev = gdev;
-
-		if (chip->request) {
-			status = chip->request(chip, i);
-			if (status < 0)
-				/* The GPIO is unavailable, so skip it */
-				continue;
-		}
-
 		/*
 		 * REVISIT: most hardware initializes GPIOs as inputs
 		 * (often with pullups enabled) so power usage is
@@ -1254,9 +1246,6 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data)
 			 */
 			set_bit(FLAG_IS_OUT, &desc->flags);
 		}
-
-		if (chip->free)
-			chip->free(chip, i);
 	}
 
 #ifdef CONFIG_PINCTRL