From: Colin Ian King <colin.king@canonical.com>
Date: Mon, 5 Jun 2017 18:08:04 +0000 (+0100)
Subject: mdio: mux: fix an incorrect less than zero error check using a u32
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=9d15e5cc8cb68326f7f89b76e04c834fe8e1a2db;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

mdio: mux: fix an incorrect less than zero error check using a u32

The u32 variable v is being checked to see if an error return is
less than zero and this check has no effect because it is unsigned.
Fix this by making v and int (this also matches the type of
cb->bus_number which is assigned to the value in v).

Detected by CoverityScan, CID#1440454 ("Unsigned compared against zero")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c
index 47ded3904050..00755b6a42cf 100644
--- a/drivers/net/phy/mdio-mux.c
+++ b/drivers/net/phy/mdio-mux.c
@@ -133,7 +133,7 @@ int mdio_mux_init(struct device *dev,
 
 	ret_val = -ENODEV;
 	for_each_available_child_of_node(dev->of_node, child_bus_node) {
-		u32 v;
+		int v;
 
 		v = of_mdio_parse_addr(dev, child_bus_node);
 		if (v < 0) {