From: Takashi Iwai Date: Tue, 5 Nov 2013 17:40:02 +0000 (+0100) Subject: ASoC: omap: Use WARN_ON() instead of BUG_ON() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=96b61bc546519ae90317980294c161c86bcd140e;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git ASoC: omap: Use WARN_ON() instead of BUG_ON() Use WARN_ON() and handle the error cases accordingly. Acked-by: Jarkko Nikula Signed-off-by: Takashi Iwai Signed-off-by: Mark Brown --- diff --git a/sound/soc/omap/n810.c b/sound/soc/omap/n810.c index 5e8d640d314f..6d216cb6c19b 100644 --- a/sound/soc/omap/n810.c +++ b/sound/soc/omap/n810.c @@ -344,8 +344,11 @@ static int __init n810_soc_init(void) clk_set_parent(sys_clkout2_src, func96m_clk); clk_set_rate(sys_clkout2, 12000000); - BUG_ON((gpio_request(N810_HEADSET_AMP_GPIO, "hs_amp") < 0) || - (gpio_request(N810_SPEAKER_AMP_GPIO, "spk_amp") < 0)); + if (WARN_ON((gpio_request(N810_HEADSET_AMP_GPIO, "hs_amp") < 0) || + (gpio_request(N810_SPEAKER_AMP_GPIO, "spk_amp") < 0))) { + err = -EINVAL; + goto err4; + } gpio_direction_output(N810_HEADSET_AMP_GPIO, 0); gpio_direction_output(N810_SPEAKER_AMP_GPIO, 0);