From: Tomi Valkeinen Date: Fri, 4 Aug 2017 09:20:03 +0000 (+0300) Subject: drm/omap: fix memory leak when FB init fails X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=95552191f0a0c3632808d8883fc05d37a5c2fe14;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git drm/omap: fix memory leak when FB init fails omap_framebuffer_create() fails to unref all the gem objects if creating the FB fails, leading to a memory leak. Fix the loop so that it goes through all the reffed gem objects. Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c index ddf7a457951b..b1a762b70cbf 100644 --- a/drivers/gpu/drm/omapdrm/omap_fb.c +++ b/drivers/gpu/drm/omapdrm/omap_fb.c @@ -379,7 +379,7 @@ struct drm_framebuffer *omap_framebuffer_create(struct drm_device *dev, return fb; error: - while (--i > 0) + while (--i >= 0) drm_gem_object_unreference_unlocked(bos[i]); return fb;