From: Jeff Garzik Date: Wed, 31 Oct 2007 11:27:57 +0000 (+0800) Subject: ata/sata_fsl: Remove unnecessary SCR cases X-Git-Tag: MMI-PSA29.97-13-9~38507^2~18 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=9465d5324834f1e99c1343b7bbdc5e6ac8c83f87;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git ata/sata_fsl: Remove unnecessary SCR cases SCRs in the driver map to the standard values found in include/linux/ata.h, so no need for individual scr_read/scr_write case statements duplicating the natural value. Signed-off-by: Jeff Garzik Signed-off-by: Li Yang Signed-off-by: Jeff Garzik --- diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index 9e99cc88340f..e04fb75e58fb 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -472,16 +472,10 @@ static int sata_fsl_scr_write(struct ata_port *ap, unsigned int sc_reg_in, switch (sc_reg_in) { case SCR_STATUS: - sc_reg = 0; - break; case SCR_ERROR: - sc_reg = 1; - break; case SCR_CONTROL: - sc_reg = 2; - break; case SCR_ACTIVE: - sc_reg = 3; + sc_reg = sc_reg_in; break; default: return -EINVAL; @@ -502,16 +496,10 @@ static int sata_fsl_scr_read(struct ata_port *ap, unsigned int sc_reg_in, switch (sc_reg_in) { case SCR_STATUS: - sc_reg = 0; - break; case SCR_ERROR: - sc_reg = 1; - break; case SCR_CONTROL: - sc_reg = 2; - break; case SCR_ACTIVE: - sc_reg = 3; + sc_reg = sc_reg_in; break; default: return -EINVAL;