From: Yannis Damigos Date: Sat, 20 Dec 2014 16:47:27 +0000 (+0200) Subject: staging: rtl8723au: Fix sparse invalid assignment warnings X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=936601e5f4473a36cbe85acea362c2552d78f5dd;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git staging: rtl8723au: Fix sparse invalid assignment warnings This is a patch to the hal/rtl8723au_xmit.c file that fixes the following warnings found by sparse tool: drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: expected unsigned int [usertype] *pdw drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: got restricted __le32 * drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: expected unsigned int [usertype] *pdw drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: got restricted __le32 * Signed-off-by: Yannis Damigos Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c index 6070510bb470..1759487329ab 100644 --- a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c +++ b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c @@ -79,7 +79,7 @@ static void fill_txdesc_sectype(struct pkt_attrib *pattrib, struct tx_desc *ptxd } } -static void fill_txdesc_vcs(struct pkt_attrib *pattrib, u32 *pdw) +static void fill_txdesc_vcs(struct pkt_attrib *pattrib, __le32 *pdw) { /* DBG_8723A("cvs_mode =%d\n", pattrib->vcs_mode); */ @@ -114,7 +114,7 @@ static void fill_txdesc_vcs(struct pkt_attrib *pattrib, u32 *pdw) } } -static void fill_txdesc_phy(struct pkt_attrib *pattrib, u32 *pdw) +static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw) { if (pattrib->ht_en) { *pdw |= (pattrib->bwmode&HT_CHANNEL_WIDTH_40) ? cpu_to_le32(BIT(25)) : 0;