From: Ed Lin Date: Sat, 19 Dec 2009 01:34:51 +0000 (-0800) Subject: [SCSI] stex: fix scan of nonexistent lun X-Git-Tag: MMI-PSA29.97-13-9~25257^2~6 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=91e6ecada757a6e2ef7b937634af8a04376772a1;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git [SCSI] stex: fix scan of nonexistent lun During a manual scan, a user can send command to a nonexistent lun, precisely at the point of max_lun. Normally it's possible (but not required) that the firmware has the knowledge that it is an invalid lun. In the particular case when max_lun is 256, however, the nonexistent lun 256 will be confused with lun 0, because the lun member in a request message is only u8, and 256 will become 0. So we need to fix the problem, at least, at the driver level. Signed-off-by: Ed Lin Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 3058bb1aff95..fd7b15be7640 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -623,6 +623,11 @@ stex_queuecommand(struct scsi_cmnd *cmd, void (* done)(struct scsi_cmnd *)) } break; case INQUIRY: + if (lun >= host->max_lun) { + cmd->result = DID_NO_CONNECT << 16; + done(cmd); + return 0; + } if (id != host->max_id - 1) break; if (!lun && !cmd->device->channel &&