From: Jesper Juhl Date: Wed, 7 Mar 2012 19:09:34 +0000 (+0000) Subject: dm ioctl: do not leak argv if target message only contains whitespace X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git dm ioctl: do not leak argv if target message only contains whitespace If 'argc' is zero we jump to the 'out:' label, but this leaks the (unused) memory that 'dm_split_args()' allocated for 'argv' if the string being split consisted entirely of whitespace. Jump to the 'out_argv:' label instead to free up that memory. Signed-off-by: Jesper Juhl Cc: stable@kernel.org Signed-off-by: Alasdair G Kergon --- diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 31c2dc25886d..1ce84ed0b765 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -1437,7 +1437,7 @@ static int target_message(struct dm_ioctl *param, size_t param_size) if (!argc) { DMWARN("Empty message received."); - goto out; + goto out_argv; } table = dm_get_live_table(md);