From: joshuaruesweg <ruesweg@woltlab.com>
Date: Fri, 30 Apr 2021 12:48:57 +0000 (+0200)
Subject: Fix collision for comment react button and comment response react button
X-Git-Tag: 5.4.0_Alpha_1~12^2~2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=8fa301cbd100799dbe3d30fe3de2c67788fa4526;p=GitHub%2FWoltLab%2FWCF.git

Fix collision for comment react button and comment response react button

The comment react button can bind onto the comment response react button, if there is no comment react button (e.g. because the comment author is the user themselves). Using an own `buttonSelector` for the comment response react button, fixes the problem.

Note: The problem only becomes visible if there is only one reaction (so WoltLab Suite uses the legacy like mode).
---

diff --git a/com.woltlab.wcf/templates/__commentJavaScript.tpl b/com.woltlab.wcf/templates/__commentJavaScript.tpl
index aa34a48960..7cace22764 100644
--- a/com.woltlab.wcf/templates/__commentJavaScript.tpl
+++ b/com.woltlab.wcf/templates/__commentJavaScript.tpl
@@ -28,7 +28,8 @@
 					// selectors
 					containerSelector: '#{@$commentContainerID} .commentResponse',
 					summaryListSelector: '.reactionSummaryList',
-					isButtonGroupNavigation: true
+					isButtonGroupNavigation: true,
+					buttonSelector: '.reactButtonCommentResponse'
 				});
 			});
 		{/if}
diff --git a/com.woltlab.wcf/templates/commentResponseList.tpl b/com.woltlab.wcf/templates/commentResponseList.tpl
index 9cd0af5618..90fd8b28e1 100644
--- a/com.woltlab.wcf/templates/commentResponseList.tpl
+++ b/com.woltlab.wcf/templates/commentResponseList.tpl
@@ -50,7 +50,7 @@
 								<li class="jsReportCommentResponse jsOnly" data-object-id="{@$response->responseID}"><a href="#" title="{lang}wcf.moderation.report.reportContent{/lang}" class="jsTooltip"><span class="icon icon16 fa-exclamation-triangle"></span> <span class="invisible">{lang}wcf.moderation.report.reportContent{/lang}</span></a></li>
 							{/if}
 							
-							{if MODULE_LIKE && $commentManager->supportsLike() && $__wcf->session->getPermission('user.like.canLike') && $response->userID != $__wcf->user->userID}<li class="jsOnly"><a href="#" class="reactButton jsTooltip {if $likeData[response][$response->responseID]|isset && $likeData[response][$response->responseID]->reactionTypeID} active{/if}" title="{lang}wcf.reactions.react{/lang}" data-reaction-type-id="{if $likeData[response][$response->responseID]|isset && $likeData[response][$response->responseID]->reactionTypeID}{$likeData[response][$response->responseID]->reactionTypeID}{else}0{/if}"><span class="icon icon16 fa-smile-o"></span> <span class="invisible">{lang}wcf.reactions.react{/lang}</span></a></li>{/if}
+							{if MODULE_LIKE && $commentManager->supportsLike() && $__wcf->session->getPermission('user.like.canLike') && $response->userID != $__wcf->user->userID}<li class="jsOnly"><a href="#" class="reactButtonCommentResponse jsTooltip {if $likeData[response][$response->responseID]|isset && $likeData[response][$response->responseID]->reactionTypeID} active{/if}" title="{lang}wcf.reactions.react{/lang}" data-reaction-type-id="{if $likeData[response][$response->responseID]|isset && $likeData[response][$response->responseID]->reactionTypeID}{$likeData[response][$response->responseID]->reactionTypeID}{else}0{/if}"><span class="icon icon16 fa-smile-o"></span> <span class="invisible">{lang}wcf.reactions.react{/lang}</span></a></li>{/if}
 							
 							{event name='commentOptions'}
 						</ul>