From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: Tue, 11 Aug 2015 12:50:50 +0000 (+0100)
Subject: greybus: connection: fix jump label on device_add failure
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=8ebc998f5fb146b7304fb7ac4e4d80059b6197fe;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

greybus: connection: fix jump label on device_add failure

On device_add() failure in gb_connection_create_range() we jump to
err_remove_ida. Instead we should be jumping to err_free_connection, so
change the flow to accomodate.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 88383b6e603f..3765aa87ef2d 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -238,7 +238,7 @@ gb_connection_create_range(struct greybus_host_device *hd,
 		pr_err("failed to add connection device for cport 0x%04hx\n",
 			cport_id);
 
-		goto err_remove_ida;
+		goto err_free_connection;
 	}
 
 	spin_lock_irq(&gb_connections_lock);