From: Laurent Pinchart Date: Fri, 5 Feb 2010 00:43:37 +0000 (-0300) Subject: V4L/DVB: uvcvideo: Check uvc_ctrl_begin return value in VIDIOC_S_CTRL X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=8d55662512127c84ac90873fb68ba44842e2c426;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git V4L/DVB: uvcvideo: Check uvc_ctrl_begin return value in VIDIOC_S_CTRL The function return value wasn't checked due to a missing variable assignment. Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c index bf1fc7f29ca7..43152aa52227 100644 --- a/drivers/media/video/uvc/uvc_v4l2.c +++ b/drivers/media/video/uvc/uvc_v4l2.c @@ -539,7 +539,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg) xctrl.id = ctrl->id; xctrl.value = ctrl->value; - uvc_ctrl_begin(chain); + ret = uvc_ctrl_begin(chain); if (ret < 0) return ret;