From: xypron.glpk@gmx.de Date: Sun, 31 Jul 2016 11:14:23 +0000 (+0200) Subject: wan/fsl_ucc_hdlc: avoid possible NULL pointer dereference X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=8c57a3a7fab4c6be2634da4084fb33dec02c8872;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git wan/fsl_ucc_hdlc: avoid possible NULL pointer dereference All assignments to components of priv should only occur after the check if prif is NULL. Signed-off-by: Heinrich Schuchardt Signed-off-by: David S. Miller --- diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 2fc50ec453d0..6f044450b702 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -862,7 +862,7 @@ static int uhdlc_suspend(struct device *dev) static int uhdlc_resume(struct device *dev) { struct ucc_hdlc_private *priv = dev_get_drvdata(dev); - struct ucc_tdm *utdm = priv->utdm; + struct ucc_tdm *utdm; struct ucc_tdm_info *ut_info; struct ucc_fast __iomem *uf_regs; struct ucc_fast_private *uccf; @@ -877,6 +877,7 @@ static int uhdlc_resume(struct device *dev) if (!netif_running(priv->ndev)) return 0; + utdm = priv->utdm; ut_info = priv->ut_info; uf_info = &ut_info->uf_info; uf_regs = priv->uf_regs;