From: Steven Rostedt Date: Fri, 22 Apr 2011 02:41:35 +0000 (-0400) Subject: ftrace: Remove unnecessary disabling of irqs X-Git-Tag: MMI-PSA29.97-13-9~19718^2~16^2~6 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=8ab2b7efd3e2ccf2c2dda3206b8171ecdbd0af40;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git ftrace: Remove unnecessary disabling of irqs The disabling of interrupts around ftrace_update_code() was used to protect against the evil ftrace daemon from years past. But that daemon has long been killed. It is safe to keep interrupts enabled while updating the initial mcount into nops. The ftrace_mutex is also held which keeps other users at bay. Signed-off-by: Steven Rostedt --- diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 4ff65599c973..f199fb2e1d2c 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -2707,7 +2707,6 @@ static int ftrace_process_locs(struct module *mod, { unsigned long *p; unsigned long addr; - unsigned long flags; mutex_lock(&ftrace_lock); p = start; @@ -2724,10 +2723,7 @@ static int ftrace_process_locs(struct module *mod, ftrace_record_ip(addr); } - /* disable interrupts to prevent kstop machine */ - local_irq_save(flags); ftrace_update_code(mod); - local_irq_restore(flags); mutex_unlock(&ftrace_lock); return 0;