From: Geert Uytterhoeven Date: Sat, 7 May 2011 13:08:36 +0000 (+0200) Subject: sparc: _sparc_find_resource() should check for exact matches X-Git-Tag: MMI-PSA29.97-13-9~18714^2~8 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=88efd0bbc0fe403a9948e6f94cc48b9f15ee4861;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git sparc: _sparc_find_resource() should check for exact matches The address that's passed to _sparc_find_resource() should always be the start address of a resource: - iounmap() passes a page-aligned virtual address, while the original address was created by adding the in-page offset to the resource's start address, - sbus_free_coherent() and pci32_free_coherent() should be passed an address obtained from sbus_alloc_coherent() resp. pci32_alloc_coherent(), which is always a resource's start address. Hence replace the range check by a check for an exact match. Signed-off-by: Geert Uytterhoeven Acked-by: David S. Miller --- diff --git a/arch/sparc/kernel/ioport.c b/arch/sparc/kernel/ioport.c index 1c9c80a1a86a..b5e83beb5b6b 100644 --- a/arch/sparc/kernel/ioport.c +++ b/arch/sparc/kernel/ioport.c @@ -723,12 +723,12 @@ static const struct file_operations sparc_io_proc_fops = { * This probably warrants some sort of hashing. */ static struct resource *_sparc_find_resource(struct resource *root, - unsigned long hit) + unsigned long start) { struct resource *tmp; for (tmp = root->child; tmp != 0; tmp = tmp->sibling) { - if (tmp->start <= hit && tmp->end >= hit) + if (tmp->start == start) return tmp; } return NULL;