From: Tim Düsterhus Date: Thu, 4 Feb 2021 13:03:39 +0000 (+0100) Subject: Document that the StyleHandler is final now (#126) X-Git-Tag: 5.6.final~312 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=88a3410f3a1f5364c8779cfbe2888f5a974949f3;p=GitHub%2FWoltLab%2Fwoltlab.github.io.git Document that the StyleHandler is final now (#126) Resolves #125 Co-authored-by: Matthias Schmidt --- diff --git a/docs/migration/wsc53/php.md b/docs/migration/wsc53/php.md index 9626c59e..98bb62d7 100644 --- a/docs/migration/wsc53/php.md +++ b/docs/migration/wsc53/php.md @@ -80,3 +80,11 @@ If you implemented a custom search engine and relied on this method, you can inl You should take the time to verify the rewritten queries against the manual of the search engine to make sure it cannot generate malformed queries or security issues. See [WoltLab/WCF#3815](https://github.com/WoltLab/WCF/issues/3815) for details. + +## Styles + +The `StyleCompiler` class is marked `final` now. +The internal SCSS compiler object being stored in the `$compiler` property was a design issue that leaked compiler state across multiple compiled styles, possibly causing misgenerated stylesheets. +As the removal of the `$compiler` property effectively broke compatibility within the `StyleCompiler` and as the `StyleCompiler` never was meant to be extended, it was marked final. + +See [WoltLab/WCF#3929](https://github.com/WoltLab/WCF/pull/3929) for details.