From: Thomas Meyer Date: Tue, 29 Nov 2011 21:08:00 +0000 (+0100) Subject: usb: gadget: renesas_usbhs: Use kcalloc instead of kzalloc to allocate array X-Git-Tag: MMI-PSA29.97-13-9~17726^2~37 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=87763842b7014a7c6d9e992785e4c711c0085974;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git usb: gadget: renesas_usbhs: Use kcalloc instead of kzalloc to allocate array The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c index bade761a1e52..75659e0c735d 100644 --- a/drivers/usb/renesas_usbhs/mod_host.c +++ b/drivers/usb/renesas_usbhs/mod_host.c @@ -1268,7 +1268,7 @@ int usbhs_mod_host_probe(struct usbhs_priv *priv) return -ENOMEM; } - pipe_info = kzalloc(sizeof(*pipe_info) * pipe_size, GFP_KERNEL); + pipe_info = kcalloc(pipe_size, sizeof(*pipe_info), GFP_KERNEL); if (!pipe_info) { dev_err(dev, "Could not allocate pipe_info\n"); goto usbhs_mod_host_probe_err;