From: Olaf Braun <olaf_schmitz_1@t-online.de>
Date: Wed, 3 Jul 2024 12:08:18 +0000 (+0200)
Subject: Apply suggestions from code review
X-Git-Tag: 6.1.0_Alpha_1~41^2~1^2
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=875395739afb40b58019315591fab05a5ea0ea90;p=GitHub%2FWoltLab%2FWCF.git

Apply suggestions from code review

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
---

diff --git a/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts b/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts
index b4fd565ca6..291a68fbab 100644
--- a/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts
+++ b/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts
@@ -17,7 +17,8 @@ import {
 } from "WoltLabSuite/Core/Component/File/File";
 import { clearPreviousErrors } from "WoltLabSuite/Core/Component/File/Upload";
 
-const _data = new Map<string, FileProcessor>();
+type FileId = string;
+const fileProcessors = new Map<FieldId, FileProcessor>();
 
 export interface ExtraButton {
   title: string;
diff --git a/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php b/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php
index d770ef4ff8..d38534d8b9 100644
--- a/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php
+++ b/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php
@@ -240,8 +240,8 @@ final class FileProcessor extends SingletonFactory
 
     public function hasReachedUploadLimit(IFileProcessor $fileProcessor, array $context): bool
     {
-        // Replace button from `FileProcessorFormField` is clicked.
-        if (!empty($context["__replace"])) {
+        $isReplacement = $context['__replace'] ?? false;
+        if ($isReplacement) {
             return false;
         }