From: Phil Sutter Date: Fri, 28 Nov 2008 19:46:22 +0000 (+0100) Subject: MIPS: RB532: remove useless CF GPIO initialisation X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=84c2c562c101bd84ea0f796b9838296da1bf859e;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git MIPS: RB532: remove useless CF GPIO initialisation As the pata-rb532-cf driver calls gpio_direction_input(), the calls to rb532_gpio_set_func() and rb532_gpio_direction_input() are not needed since the alternate function is automatically being disabled when changing the GPIO pin direction. The later two calls to rb532_gpio_set_{ilevel,istat}() are implicitly being done by the IRQ initialisation of pata-rb532-cf. Signed-off-by: Phil Sutter Signed-off-by: Ralf Baechle --- diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c index f5b15a17432..b195f797c43 100644 --- a/arch/mips/rb532/gpio.c +++ b/arch/mips/rb532/gpio.c @@ -259,12 +259,6 @@ int __init rb532_gpio_init(void) return -ENXIO; } - /* configure CF_GPIO_NUM as CFRDY IRQ source */ - rb532_gpio_set_func(0, CF_GPIO_NUM); - rb532_gpio_direction_input(&rb532_gpio_chip->chip, CF_GPIO_NUM); - rb532_gpio_set_ilevel(1, CF_GPIO_NUM); - rb532_gpio_set_istat(0, CF_GPIO_NUM); - return 0; } arch_initcall(rb532_gpio_init);