From: Rabin Vincent Date: Thu, 6 Apr 2017 08:16:23 +0000 (+0200) Subject: spi: pl022: don't use uninitialized variable X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=849794c50b24b93676b939028c811d6e116ef335;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git spi: pl022: don't use uninitialized variable The num-cs property is a required property according to the binding documentation. However, if it is not present, the driver currently simply uses random junk from the stack for the num-cs since the variable whose pointer is passed to of_property_read_u32() is not initialized. Signed-off-by: Rabin Vincent Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index f7f7ba17b40e..2f76e022cc59 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2074,7 +2074,7 @@ pl022_platform_data_dt_get(struct device *dev) { struct device_node *np = dev->of_node; struct pl022_ssp_controller *pd; - u32 tmp; + u32 tmp = 0; if (!np) { dev_err(dev, "no dt node defined\n");