From: Damien Lespiau Date: Thu, 13 Feb 2014 18:56:15 +0000 (+0000) Subject: drm/i915/lvds: Remove dead code from failing case X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=7fb4a3a31ffc8c7fa69258e92336ccf78ca5e2b5;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git drm/i915/lvds: Remove dead code from failing case Coverity points out that, if we end up in the 'failed' label, that's precisely because we couldn't retrieve a fixed mode (ie fixed_mode is NULL) and then "if (fixed_mode)" is always false. Remove that dead code. Signed-off-by: Damien Lespiau Reviewed-by: Paulo Zanoni Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index 6341a8873d28..398460862be6 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -1125,8 +1125,6 @@ failed: DRM_DEBUG_KMS("No LVDS modes found, disabling.\n"); drm_connector_cleanup(connector); drm_encoder_cleanup(encoder); - if (fixed_mode) - drm_mode_destroy(dev, fixed_mode); kfree(lvds_encoder); kfree(lvds_connector); return;