From: Lars-Peter Clausen Date: Sat, 21 Nov 2015 11:01:22 +0000 (+0100) Subject: ALSA: azt3328: Remove unnecessary synchronize_irq() before free_irq() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=7a7a2df434cec5614271666b84b2ea1f41048e91;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git ALSA: azt3328: Remove unnecessary synchronize_irq() before free_irq() Calling synchronize_irq() right before free_irq() is quite useless. On one hand the IRQ can easily fire again before free_irq() is entered, on the other hand free_irq() itself calls synchronize_irq() internally (in a race condition free way) before any state associated with the IRQ is freed. Signed-off-by: Lars-Peter Clausen Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/azt3328.c b/sound/pci/azt3328.c index 07a4acc99541..5e2ef0bb7057 100644 --- a/sound/pci/azt3328.c +++ b/sound/pci/azt3328.c @@ -2294,8 +2294,6 @@ snd_azf3328_free(struct snd_azf3328 *chip) snd_azf3328_timer_stop(chip->timer); snd_azf3328_gameport_free(chip); - if (chip->irq >= 0) - synchronize_irq(chip->irq); __end_hw: if (chip->irq >= 0) free_irq(chip->irq, chip);