From: Greg Kroah-Hartman <greg@kroah.com>
Date: Tue, 31 Mar 2015 21:02:34 +0000 (+0200)
Subject: greybus: loopback: use the attribute groups, not group
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=7a51b9362b547b2f02ef88c10636950637c71fa5;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

greybus: loopback: use the attribute groups, not group

We should use the attribute groups, not group, for the device, so
add and remove it.  No one should ever be updating a sysfs group for a
device, as that can be pretty dangerous if you don't duplicate _all_
existing attribute for that device, and I don't think we were doing that
here.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
---

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7003bce148ff..9914b52c71ce 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -343,7 +343,7 @@ static int gb_loopback_connection_init(struct gb_connection *connection)
 
 	gb->connection = connection;
 	connection->private = gb;
-	retval = sysfs_update_group(&connection->dev.kobj, &loopback_group);
+	retval = sysfs_create_groups(&connection->dev.kobj, loopback_groups);
 	if (retval)
 		goto error;
 
@@ -372,7 +372,7 @@ static void gb_loopback_connection_exit(struct gb_connection *connection)
 
 	if (!IS_ERR_OR_NULL(gb->task))
 		kthread_stop(gb->task);
-	sysfs_remove_group(&connection->dev.kobj, &loopback_group);
+	sysfs_remove_groups(&connection->dev.kobj, loopback_groups);
 	kfree(gb);
 }