From: Frank Rowand Date: Wed, 21 Jun 2017 19:21:56 +0000 (-0700) Subject: of: detect invalid phandle in overlay X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=7a12f459896ae1acf1d826d90b33ecff6f4508c2;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git of: detect invalid phandle in overlay Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand Signed-off-by: Rob Herring --- diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 7827786718d8..c0e4ee1cd1ba 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -132,6 +132,10 @@ static int of_overlay_apply_single_device_node(struct of_overlay *ov, /* NOTE: Multiple mods of created nodes not supported */ tchild = of_get_child_by_name(target, cname); if (tchild != NULL) { + /* new overlay phandle value conflicts with existing value */ + if (child->phandle) + return -EINVAL; + /* apply overlay recursively */ ret = of_overlay_apply_one(ov, tchild, child); of_node_put(tchild);