From: Christoph Jaeger Date: Tue, 20 Aug 2013 06:03:18 +0000 (+0930) Subject: module: fix sprintf format specifier in param_get_byte() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=79ac6834c255d9e3832209f3738d6bff7b87c743;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git module: fix sprintf format specifier in param_get_byte() In param_get_byte(), to which the macro STANDARD_PARAM_DEF(byte, ...) expands, "%c" is used to print an unsigned char. So it gets printed as a character what is not intended here. Use "%hhu" instead. [Rusty: note drivers which would be effected: drivers/net/wireless/cw1200/main.c drivers/ntb/ntb_transport.c:68 drivers/scsi/lpfc/lpfc_attr.c drivers/usb/atm/speedtch.c drivers/usb/gadget/g_ffs.c ] Acked-by: Jon Mason (for ntb) Acked-by: Michal Nazarewicz (for g_ffs.c) Signed-off-by: Christoph Jaeger Signed-off-by: Rusty Russell --- diff --git a/kernel/params.c b/kernel/params.c index 440e65d1a544..59f7ac7bec04 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -252,7 +252,7 @@ int parse_args(const char *doing, EXPORT_SYMBOL(param_ops_##name) -STANDARD_PARAM_DEF(byte, unsigned char, "%c", unsigned long, strict_strtoul); +STANDARD_PARAM_DEF(byte, unsigned char, "%hhu", unsigned long, strict_strtoul); STANDARD_PARAM_DEF(short, short, "%hi", long, strict_strtol); STANDARD_PARAM_DEF(ushort, unsigned short, "%hu", unsigned long, strict_strtoul); STANDARD_PARAM_DEF(int, int, "%i", long, strict_strtol);