From: Paul Zimmerman <Paul.Zimmerman@synopsys.com>
Date: Mon, 22 Apr 2013 21:00:18 +0000 (-0700)
Subject: staging: dwc2: check for null pointer before dereferencing it
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=7902c16b9a5b7001d79940d6b4e99366d6e525d8;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git

staging: dwc2: check for null pointer before dereferencing it

We were testing qtd->urb pointer for null after we had already
dereferenced it

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/staging/dwc2/hcd_intr.c
index a8d8c53a8b2..6e5dbed6cce 100644
--- a/drivers/staging/dwc2/hcd_intr.c
+++ b/drivers/staging/dwc2/hcd_intr.c
@@ -1377,13 +1377,12 @@ static void dwc2_hc_nyet_intr(struct dwc2_hsotg *hsotg,
 		    hsotg->core_params->dma_enable > 0) {
 			qtd->complete_split = 0;
 			qtd->isoc_split_offset = 0;
-			if (++qtd->isoc_frame_index == qtd->urb->packet_count) {
-				if (qtd->urb)
-					dwc2_host_complete(hsotg,
-							   qtd->urb->priv,
-							   qtd->urb, 0);
+			if (qtd->urb &&
+			    ++qtd->isoc_frame_index == qtd->urb->packet_count) {
+				dwc2_host_complete(hsotg, qtd->urb->priv,
+						   qtd->urb, 0);
 				dwc2_release_channel(hsotg, chan, qtd,
-						DWC2_HC_XFER_URB_COMPLETE);
+						     DWC2_HC_XFER_URB_COMPLETE);
 			} else {
 				dwc2_release_channel(hsotg, chan, qtd,
 						DWC2_HC_XFER_NO_HALT_STATUS);