From: Markus Elfring Date: Sun, 23 Nov 2014 15:30:05 +0000 (+0100) Subject: video: fbdev-VIA: Deletion of an unnecessary check before the function call "framebuf... X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=772849512798833daca4d88869c15604af3fbb9f;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git video: fbdev-VIA: Deletion of an unnecessary check before the function call "framebuffer_release" The framebuffer_release() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c index 325c43c6ff97..f9718f012aae 100644 --- a/drivers/video/fbdev/via/viafbdev.c +++ b/drivers/video/fbdev/via/viafbdev.c @@ -1937,8 +1937,7 @@ out_fb1_unreg_lcd_cle266: out_dealloc_cmap: fb_dealloc_cmap(&viafbinfo->cmap); out_fb1_release: - if (viafbinfo1) - framebuffer_release(viafbinfo1); + framebuffer_release(viafbinfo1); out_fb_release: i2c_bus_free(viaparinfo->shared); framebuffer_release(viafbinfo);