From: Javier Ferrer <javi.f.o@gmail.com>
Date: Mon, 20 May 2013 23:09:24 +0000 (+0200)
Subject: Fix macloader buffer overflow
X-Git-Tag: cm-10.1.0.1~4
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=76ea68e99b6ab1c16efcdb67485e18574c9e0865;p=GitHub%2FLineageOS%2Fandroid_hardware_samsung.git

Fix macloader buffer overflow

Fixes this log entries.

I/macloader( 1915): Writing murata to /data/.cid.info
D/macloader( 1915): Setting permissions on /data/.cid.info
F/libc    ( 1915): *** vsprintf buffer overflow detected ***
F/libc    ( 1915): Fatal signal 11 (SIGSEGV) at 0xdeadbaad (code=1), thread 1915 (macloader)

Change-Id: I1ccb257bada18030de76a2be40477172993ca2a0
---

diff --git a/macloader/macloader.cpp b/macloader/macloader.cpp
index 62397cd..b316c60 100644
--- a/macloader/macloader.cpp
+++ b/macloader/macloader.cpp
@@ -117,8 +117,8 @@ int main() {
         amode = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH;
         ret = chmod(CID_PATH, amode);
 
-        char* chown_cmd = (char*) malloc(strlen("chown system ") + strlen(CID_PATH));
-        char* chgrp_cmd = (char*) malloc(strlen("chgrp system ") + strlen(CID_PATH));
+        char* chown_cmd = (char*) malloc(strlen("chown system ") + strlen(CID_PATH) + 1);
+        char* chgrp_cmd = (char*) malloc(strlen("chgrp system ") + strlen(CID_PATH) + 1);
         sprintf(chown_cmd, "chown system %s", CID_PATH);
         sprintf(chgrp_cmd, "chgrp system %s", CID_PATH);
         system(chown_cmd);