From: Chen-Yu Tsai Date: Tue, 22 Dec 2015 04:27:35 +0000 (-0200) Subject: [media] rc: sunxi-cir: Initialize the spinlock properly X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=768acf46e1320d6c41ed1b7c4952bab41c1cde79;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git [media] rc: sunxi-cir: Initialize the spinlock properly The driver allocates the spinlock but fails to initialize it correctly. The kernel reports a BUG indicating bad spinlock magic when spinlock debugging is enabled. Call spin_lock_init() on it to initialize it correctly. Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver") Signed-off-by: Chen-Yu Tsai Acked-by: Hans de Goede Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index 7830aef3db45..40f77685cc4a 100644 --- a/drivers/media/rc/sunxi-cir.c +++ b/drivers/media/rc/sunxi-cir.c @@ -153,6 +153,8 @@ static int sunxi_ir_probe(struct platform_device *pdev) if (!ir) return -ENOMEM; + spin_lock_init(&ir->ir_lock); + if (of_device_is_compatible(dn, "allwinner,sun5i-a13-ir")) ir->fifo_size = 64; else