From: Jonathan Cameron <jic23@cam.ac.uk>
Date: Sat, 9 Jan 2010 16:57:34 +0000 (+0000)
Subject: staging: iio: Ensure mutex is correctly unlocked in __iio_push_event
X-Git-Tag: MMI-PSA29.97-13-9~24618^2~1^2~211
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=75c8075394906b4bda4b056328bd9b401277d9b8;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

staging: iio: Ensure mutex is correctly unlocked in __iio_push_event

This error was picked up by running the smatch static
checker over all the IIO subsytem.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index 768f44894d08..87799b2a9262 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -79,11 +79,14 @@ EXPORT_SYMBOL(__iio_change_event);
 	/* Does anyone care? */
 	mutex_lock(&ev_int->event_list_lock);
 	if (test_bit(IIO_BUSY_BIT_POS, &ev_int->handler.flags)) {
-		if (ev_int->current_events == ev_int->max_events)
+		if (ev_int->current_events == ev_int->max_events) {
+			mutex_unlock(&ev_int->event_list_lock);
 			return 0;
+		}
 		ev = kmalloc(sizeof(*ev), GFP_KERNEL);
 		if (ev == NULL) {
 			ret = -ENOMEM;
+			mutex_unlock(&ev_int->event_list_lock);
 			goto error_ret;
 		}
 		ev->ev.id = ev_code;