From: Leon Yu <chianglungyu@gmail.com>
Date: Thu, 1 May 2014 03:31:28 +0000 (+0000)
Subject: aio: fix potential leak in aio_run_iocb().
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=754320d6e166d3a12cb4810a452bde00afbd4e9a;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

aio: fix potential leak in aio_run_iocb().

iovec should be reclaimed whenever caller of rw_copy_check_uvector() returns,
but it doesn't hold when failure happens right after aio_setup_vectored_rw().

Fix that in a such way to avoid hairy goto.

Signed-off-by: Leon Yu <chianglungyu@gmail.com>
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
Cc: stable@vger.kernel.org
---

diff --git a/fs/aio.c b/fs/aio.c
index 2adbb0398ab9..a0ed6c7d2cd2 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1327,10 +1327,8 @@ rw_common:
 						&iovec, compat)
 			: aio_setup_single_vector(req, rw, buf, &nr_segs,
 						  iovec);
-		if (ret)
-			return ret;
-
-		ret = rw_verify_area(rw, file, &req->ki_pos, req->ki_nbytes);
+		if (!ret)
+			ret = rw_verify_area(rw, file, &req->ki_pos, req->ki_nbytes);
 		if (ret < 0) {
 			if (iovec != &inline_vec)
 				kfree(iovec);