From: Tim Düsterhus <duesterhus@woltlab.com>
Date: Sun, 14 Dec 2014 16:45:51 +0000 (+0100)
Subject: Improve behaviour of collapsed code boxes
X-Git-Tag: 2.1.0_Beta_1~1
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=753d4a591f465e906eabc153259f93e942d63e86;p=GitHub%2FWoltLab%2FWCF.git

Improve behaviour of collapsed code boxes
---

diff --git a/com.woltlab.wcf/templates/codeBBCodeTag.tpl b/com.woltlab.wcf/templates/codeBBCodeTag.tpl
index 8440095906..6b7f1eceb5 100644
--- a/com.woltlab.wcf/templates/codeBBCodeTag.tpl
+++ b/com.woltlab.wcf/templates/codeBBCodeTag.tpl
@@ -20,12 +20,34 @@
 	
 	{if $lines > 10}
 		<span class="codeBoxExpand jsButtonCodeBoxExpand">{lang}wcf.bbcode.button.showAll{/lang}</span>
-		<script data-relocate="true">
-			$(function() {
-				$('.jsButtonCodeBoxExpand').removeClass('jsButtonCodeBoxExpand').click(function() {
-					$(this).parent().removeClass('minimized').end().remove();
+		
+		{if !$__overlongCodeBoxSeen|isset}
+			{assign var='__overlongCodeBoxSeen' value=true}
+			<script data-relocate="true">
+				$(function() {
+					$('.jsButtonCodeBoxExpand').removeClass('jsButtonCodeBoxExpand').click(function() {
+						$(this).parent().removeClass('minimized').end().remove();
+					});
+					
+					// searching in a page causes Google Chrome to scroll
+					// the code box if something inside it matches
+					// 
+					// expand the box in this case, to:
+					// a) Improve UX
+					// b) Hide an ugly misplaced "show all" button
+					$('.codeBox').on('scroll', function() {
+						$(this).find('.codeBoxExpand').click();
+					});
+					
+					// expand code boxes that are initially scrolled this
+					// may happen due to someone linking to a specific line
+					$('.codeBox').each(function() {
+						if ($(this).scrollTop() != 0) {
+							$(this).find('.codeBoxExpand').click();
+						}
+					});
 				});
-			});
-		</script>
+			</script>
+		{/if}
 	{/if}
 </div>