From: Colin Ian King Date: Tue, 28 Feb 2017 11:31:15 +0000 (+0000) Subject: netfilter: arp_tables: remove redundant check on ret being non-zero X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=74664cf286dc0d2bf6960293cb219e5f741ac92b;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git netfilter: arp_tables: remove redundant check on ret being non-zero ret is initialized to zero and if it is set to non-zero in the xt_entry_foreach loop then we exit via the out_free label. Hence the check for ret being non-zero is redundant and can be removed. Detected by CoverityScan, CID#1357132 ("Logically Dead Code") Signed-off-by: Colin Ian King Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c index 6241a81fd7f5..f17dab1dee6e 100644 --- a/net/ipv4/netfilter/arp_tables.c +++ b/net/ipv4/netfilter/arp_tables.c @@ -562,8 +562,6 @@ static int translate_table(struct xt_table_info *newinfo, void *entry0, XT_ERROR_TARGET) == 0) ++newinfo->stacksize; } - if (ret != 0) - goto out_free; ret = -EINVAL; if (i != repl->num_entries)